Skip to content

Trim About's How to use and link it to the tour - #93

Merged
LaSav merged 2 commits into
mainfrom
ui/about-tour-link
Nov 17, 2026
Merged

LaSav merged 2 commits into
mainfrom
ui/about-tour-link

Conversation

@LaSav

@LaSav LaSav commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

What

Follow-up to #92, from the feedback doc ("About page: shorten it… move 'how to use' into the tour").

  • About → How to use: the three-step Quick start list becomes one short paragraph. A Take the tour link follows it on desktop only, because the tour lives in the graph view and phones don't have it. The Views list and the storage-limits note stay, since they cover phones and caveats the tour doesn't.
  • Take the tour goes to / with router state { tour: true }. GraphView opens the tour once a graph with papers is showing (the same rules as auto-start: after any modal or discard prompt), even if it was seen before. The request is used up when the tour opens, and the router state is cleared, so a reload or Back doesn't repeat it.
  • Hook: useNewGraphRequest.ts is renamed to useRouteRequest.ts. It now handles both newGraph (About's "Create a graph") and tour, and the existing useNewGraphRequest export behaves the same.

Testing

  • npm run typecheck, npm run lint and npm test pass (120 tests)
  • Checked manually in Chrome against the local API, with the tour already marked as seen:
    • Take the tour opens the tour on / and clears the router state.
    • Esc closes it, and a reload doesn't bring it back.
    • About's Create a graph still opens the new-graph modal, with no tour on top.

🤖 Generated with Claude Code

The three-step quick start becomes one paragraph, plus a desktop-only
"Take the tour" link that opens the graph view with the tour showing,
even if it was seen before. The router-state hook behind About's
"Create a graph" now carries both requests (useRouteRequest).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@netlify

netlify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for alignment-graph ready!

Name Link
🔨 Latest commit 2332fcb
🔍 Latest deploy log https://app.netlify.com/projects/alignment-graph/deploys/6afb9904551f27d413692cb8
😎 Deploy Preview https://deploy-preview-93--alignment-graph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

"Take the tour" from About did nothing visible when the active graph
was empty, then sprang the tour later. An explicit request now opens it
as soon as no modal or discard prompt is in the way; the automatic
start still waits for a graph with papers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LaSav

LaSav commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

AI review: AI-CLEARED

Reviewed 7ddd578 against main; finding 1 fixed in 2332fcb (CI green).

Findings

# Severity Confidence Location Finding Status
1 low confirmed ui/src/components/GraphView.tsx:383 A tour request from About still waits for hasPapers. If a returning user's active saved graph shows zero papers, "Take the tour" does nothing visible, and the tour appears later, unexpectedly, the next time a graph with papers loads. Fixed: an explicit request no longer waits for papers; the automatic start still does
2 low plausible ui/src/components/GraphView.tsx:289 The request lives only in a ref, and router state is cleared on mount. If the window is narrowed below md before the tour opens, GraphView unmounts (/ swaps to BrowseView) and the request is lost. Accepted: needs a resize below tablet width within ~0.5s of clicking

Checked and fine

  • Two route-request hooks in GraphView: only the requested key navigates, and the replace keeps the URL search, so share params survive. Nothing else reads location.state.
  • StrictMode double mount: the request is consumed once.
  • Tour button racing the timer: handled in both orders.
  • Visitors with no saved graphs: the new-graph modal comes first, then the tour.
  • Share links: the tour opens once the shared graph has papers.
  • Imports: nothing imports the old useNewGraphRequest.ts path.
  • Phones: the link is hidden below md. If it's used anyway, BrowseView ignores the request.
  • Invariants: none touched. The PR has no aid/id use, data fetching, tag, embedding or API changes.

No risk paths triggered: the diff is limited to UI components and a hook.

@LaSav
LaSav merged commit 8713b6b into main Nov 17, 2026
7 checks passed
@LaSav
LaSav deleted the ui/about-tour-link branch November 17, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant